Update Search Relevance Workbench Tests - #1941
Draft
wrigleyDan wants to merge 1 commit into
Draft
Conversation
Signed-off-by: wrigleyDan <dwrigley@opensourceconnections.com>
wrigleyDan
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
March 18, 2026 10:16
Author
|
I'm seeing there is some redundancy in #1940 |
wrigleyDan
marked this pull request as draft
March 18, 2026 10:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During the development of opensearch-project/dashboards-search-relevance#804 the integration tests failed due to previous changes in
dashboards-search-relevance. This PR updates the tests according to these changes and fixes linting errors:singleQueryComparison→queryAnalysisThe plugin renamed its "Single Query Comparison" template to "Query Analysis", changing the route from
singleQueryComparisontoqueryAnalysis.cy.waitForLoader()callswaitForLoader()checks for[data-test-subj="homeIcon"], which only exists in the legacy OSD header. Whenhome:useNewHomePage = trueis set in the OSD environment, the legacy header is not rendered and homeIcon never appears, causing a 60-second timeout.Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.